Updated the code to use spaces instead of tabs with a space indentation of 4 spaces#65
Conversation
…per indentation. Added a jshint file to validate against.
|
Looking at the code guidelines for the angular project their .jshintrc file is a spacing of 2. Its also the default spacing for the angular yeoman generator. I will update this PR with those rules. Any other collaborators are free to comment. |
|
The default spacing is 4 with jshint and jslint: Two spaces seem to be more common (unfortunately): |
|
@panuhorsmalahti - That's correct the default .jshintrc is set to 4 spaces. That's why the PR above is set to 4. Looking at this: https://github.com/angular/angular.js/blob/master/.jshintrc-base shows that the developers behind the core of which this service is built is using 2. I think that we should be using 2 as it is more common, and it's also what the core developers behind the framework uses. |
…sides whitespace changes.
|
@aaunel @agrublev @voronianski - Do you three have any say in this? The code will use 2 spaces (not tabs) for indentation and the .jshintrc file reflects the same that is used for the core AngularJS project. |
|
@hppycoder personally I don't like 2 spaces indentation.. but I'm not often committing there so it's up to you. |
|
I like the 2 spaces, it's what AngularJS uses, it's what comes default with most IDEs, and most of the ones who use .jshintrc are using. I think I will merge this, if we hate it we can always change it. |
Updated the code to use spaces instead of tabs with a space indentation of 2 spaces
3 participants
Updated the code to use spaces instead of tabs, and added a jshint file to help additional collaboration efforts.
Code was untouched, starts a discussion about the change from tabs to spaces and implementing a jshint file.