fix(web): group insights results by platform - #235
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to Ansvisor, and thank you for your first PR! A maintainer will be by soon to review.
In the meantime, two things that make review faster:
- A short description of why the change matters, not just what it does — most of our PRs link a
Fixes #...to the issue that explains the why. - A quick local test note if there's anything worth eyeballing in the browser.
If you'd like to keep an eye on where Ansvisor goes next, a ⭐ on the repo helps others discover it (and Watch sends you a ping when related issues land). Either way — looking forward to your next one.
|
Thanks for the quick review and merge. PCF helped keep this contribution narrow on my side: it checked for overlapping PRs, kept the change scoped to the insights grouping path, and made sure the project validation passed before I opened it. Appreciate the fast turnaround. |
|
Thanks for the great work, @VrtxOmega! 🙌 Clean, well-scoped change — and extracting the grouping into a unit-tested If you're up for it, there's a sibling of this exact bug: the prompt detail page ( |
2 participants
Summary
Related issue
Closes #231
Type of change
feat- New featurefix- Bug fixchore- Maintenance / dependenciesdocs- Documentation onlyrefactor- Code change that neither fixes a bug nor adds a featuretest- Adding or updating testsValidation
corepack yarn test 'src/app/[locale]/(dashboard)/dashboard/insights/grouping.test.ts'corepack yarn prettier --check 'src/app/[locale]/(dashboard)/dashboard/insights/page.tsx' 'src/app/[locale]/(dashboard)/dashboard/insights/grouping.ts' 'src/app/[locale]/(dashboard)/dashboard/insights/grouping.test.ts'corepack yarn eslint 'src/app/[locale]/(dashboard)/dashboard/insights/page.tsx' 'src/app/[locale]/(dashboard)/dashboard/insights/grouping.ts' 'src/app/[locale]/(dashboard)/dashboard/insights/grouping.test.ts'corepack yarn format:checkcorepack yarn testcorepack yarn typecheckcorepack yarn lint(0 errors; existing unrelated warnings remain in other files)git diff --cached --checkChecklist
feature/,fix/,chore/,docs/) - see CONTRIBUTING.mdyarn lintpasses (run fromweb/)yarn typecheckpasses (run fromweb/)yarn format:checkpasses (run fromweb/)