chore: remove stale tar override - #846
Closed
AnujVishwakarma-src wants to merge 1 commit into
Closed
AnujVishwakarma-src wants to merge 1 commit into
AnujVishwakarma-src wants to merge 1 commit into
Conversation
check-overrides.js reports tar as no longer needed (npm audit vulnerability count is identical with or without it), and the prepack governance check now fails the on-push-publish-to-npm workflow until it's removed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Closing — confirmed this is unsafe. Removing the Root-caused and fixed in #847 (severity-bucket-aware comparison). Keeping the override in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
tarentry fromoverridesinpackage.json.bin/check-overrides.js(this repo's own governance script, run as part ofprepack) now reportstaras no longer needed —npm auditproduces the identical vulnerability count with or without it. Sinceprepackfails the build when a removable override is detected, this was blocking theon-push-publish-to-npmworkflow on the 11.1.3 release commit.@octokit/restand@yeoman/conflicter > diffoverrides are kept — removing either still adds vulnerabilities per the same check.Validated
npm run check-overrides: exits 0 (previously exited 1, blocking publish).npm audit: 54 vulnerabilities, unchanged from baseline with the override in place.npm test: 53/53 tests pass, 100% coverage, lint clean.The lockfile diff is larger than a single-line removal because
tarhas three separate consumers (cacache,node-gyp,pacote) that each now resolve their own version once nothing forces a single deduped one — confirmed via both a normalnpm installand a from-scratch--package-lock-onlyresolve producing the same result, so this isn't local drift.