Skip to content

⬆️ Updated from JUnit 4 to JUnit 5 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rombert merged 1 commit into from
Sep 22, 2025
Merged

⬆️ Updated from JUnit 4 to JUnit 5 #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions com.adobe.granite.ide.eclipse-ui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@

<dependencies>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>5.13.4</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
Expand Down
13 changes: 7 additions & 6 deletions ...e.eclipse-ui/src/test/java/com/adobe/granite/ide/eclipse/ui/wizards/np/PropUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
package com.adobe.granite.ide.eclipse.ui.wizards.np;

import static org.junit.Assert.assertEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.LinkedHashMap;
import java.util.Map;

import org.apache.maven.archetype.metadata.RequiredProperty;

import org.apache.maven.shared.utils.StringUtils;
import org.junit.Test;
import org.junit.jupiter.api.Test;

@SuppressWarnings("restriction")
public class PropUtilsTest {
class PropUtilsTest {

private Map<String, RequiredPropertyWrapper> getProperties(String[][] props) {
Map<String, RequiredPropertyWrapper> properties = new LinkedHashMap<String, RequiredPropertyWrapper>();
Expand All @@ -25,9 +26,9 @@ private Map<String, RequiredPropertyWrapper> getProperties(String[][] props) {
}
return properties;
}

@Test
public void testUpdateProperties() {
void updateProperties() {
Map<String, RequiredPropertyWrapper> properties = getProperties(new String[][] {
new String[] {
"unmodified", "", "DEFAULT_UNMODIFIED", ""
Expand Down Expand Up @@ -82,6 +83,6 @@ private void printProperties(Map<String, RequiredPropertyWrapper> properties) {
}

private String pad(Object obj) {
return StringUtils.rightPad(StringUtils.defaultString(String.valueOf(obj), ""), 30);
return StringUtils.rightPad(String.valueOf(obj), 30);
}
}