Skip to content

⬆️ Updated from JUnit 4 to JUnit 5#126

Merged
rombert merged 1 commit into
adobe:masterfrom
rmcdouga:update_to_junit5
Sep 22, 2025
Merged

⬆️ Updated from JUnit 4 to JUnit 5#126
rombert merged 1 commit into
adobe:masterfrom
rmcdouga:update_to_junit5

Conversation

@rmcdouga

Copy link
Copy Markdown
Contributor

Migrate from JUnit 4 to JUnit 5

Description

Updated pom.xml and the single unit test. Made the test methods package private and removed the "test" prefix in method name, per JUnit 5 best practices.

Related Issue

#125

Motivation and Context

JUnit 4 was been replaced by JUnit 5 approximately 8 years ago.

How Has This Been Tested?

Ran maven verify to prove the tests still pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rombert rombert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @rmcdouga !

@rombert rombert merged commit 990de41 into adobe:master Sep 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants