Skip to content

2026.05#73

Merged
fbaba-adobe merged 1 commit into
mainfrom
fbaba/security-fix-ngp
May 22, 2026
Merged

2026.05#73
fbaba-adobe merged 1 commit into
mainfrom
fbaba/security-fix-ngp

Conversation

@fbaba-adobe
Copy link
Copy Markdown
Collaborator

Security fixes:

  • importUncompressedFloatArray now checks decoded base64 size against expected d1 * d2 dimensions before calling unpackMLPWeight(); rejects undersized buffers with TF_WARN instead of overflowing the destination.
  • Bias path (d1 == 0 || d2 == 0) guards against zero-length data and limits the memcpy to whole floats only, preventing a heap-buffer overflow on inputs whose byte length is not a multiple of 4.

Also bumps version.json to 2026.05 and adds a v2026.5 changelog entry.

Backport of input validation for the ADOBE_nerf_asset extension in
gltfImport.cpp:

- importUncompressedFloatArray now checks decoded base64 size against
  expected d1 * d2 dimensions before calling unpackMLPWeight(); rejects
  undersized buffers with TF_WARN instead of overflowing the destination.
- Bias path (d1 == 0 || d2 == 0) guards against zero-length data and
  limits the memcpy to whole floats only, preventing a heap-buffer
  overflow on inputs whose byte length is not a multiple of 4.

Also bumps version.json to 2026.05 and adds a v2026.5 changelog entry.
Copy link
Copy Markdown
Contributor

@jakes-adobe jakes-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Copy Markdown

@paule-adobe paule-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbaba-adobe fbaba-adobe merged commit f064453 into main May 22, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants