putting it in the services layer isn't lovely either [email_in_services]

hjwp · hjwp · commit c2bbd9f72194 · 2020-01-08T20:41:48.000Z
diff --git a/src/allocation/domain/model.py b/src/allocation/domain/model.py
@@ -2,7 +2,6 @@
 from dataclasses import dataclass
 from datetime import date
 from typing import Optional, List, Set
-from allocation.adapters import email
 
 
 class OutOfStock(Exception):
@@ -25,7 +24,6 @@ def allocate(self, line: OrderLine) -> str:
             self.version_number += 1
             return batch.reference
         except StopIteration:
-            email.send_mail('stock@made.com', f'Out of stock for {line.sku}')
             raise OutOfStock(f'Out of stock for sku {line.sku}')
 
 
@@ -82,4 +80,3 @@ def available_quantity(self) -> int:
 
     def can_allocate(self, line: OrderLine) -> bool:
         return self.sku == line.sku and self.available_quantity >= line.qty
-
diff --git a/src/allocation/service_layer/services.py b/src/allocation/service_layer/services.py
@@ -2,6 +2,7 @@
 from typing import Optional
 from datetime import date
 
+from allocation.adapters import email
 from allocation.domain import model
 from allocation.domain.model import OrderLine
 from allocation.service_layer import unit_of_work
@@ -33,6 +34,10 @@ def allocate(
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise InvalidSku(f'Invalid sku {line.sku}')
-        batchref = product.allocate(line)
-        uow.commit()
-    return batchref
+        try:
+            batchref = product.allocate(line)
+            uow.commit()
+            return batchref
+        except model.OutOfStock:
+            email.send_mail('stock@made.com', f'Out of stock for {line.sku}')
+            raise
