Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CoderKungfu/php-queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: adamwight/php-queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 3 files changed
  • 3 contributors

Commits on May 7, 2015

  1. Fix typo in Stomp backend

    Adam Roses Wight
    Adam Roses Wight committed May 7, 2015
    Configuration menu
    Copy the full SHA
    6a6d5fe View commit details
    Browse the repository at this point in the history

  2. Explicitly serialize using JSON for memcached messages 

    Otherwise we are defaulting to the PHP serializer.
    Adam Roses Wight
    Adam Roses Wight committed May 7, 2015
    Configuration menu
    Copy the full SHA
    31413e9 View commit details
    Browse the repository at this point in the history

  3. Silently ignore headers, and incompatible function signature 

    This is all kinds of FIXME.  Decide whether we need headers or additional
indexes for payments use cases.  Reconcile set() signature in Stomp and
Memcache backends.
    Adam Roses Wight
    Adam Roses Wight committed May 7, 2015
    Configuration menu
    Copy the full SHA
    fc0dae3 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2015

  1. Correct Redis incr/decr when count > 1

    Adam Roses Wight
    Adam Roses Wight committed May 14, 2015
    Configuration menu
    Copy the full SHA
    5644b41 View commit details
    Browse the repository at this point in the history

  2. Sleazy way of making all our keys available 

    TODO: This needs to be provided by a generalized API.

Bug: https://phabricator.wikimedia.org/T99017
    Adam Roses Wight
    Adam Roses Wight committed May 14, 2015
    Configuration menu
    Copy the full SHA
    1cb3c83 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2015

  1. Implement pop & push for Memcache 

    FIXME: Bucket contents need a cas token if we ever run multiple
consumers at once.
    @ejegg
    ejegg committed May 21, 2015
    Configuration menu
    Copy the full SHA
    5909942 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2015

  1. Merge pull request #2 from ejegg/master 

    Implement pop & push for Memcache
    @adamwight
    adamwight committed May 22, 2015
    Configuration menu
    Copy the full SHA
    f18bba4 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2015

  1. Don't double-encode

    Adam Roses Wight
    Adam Roses Wight committed May 29, 2015
    Configuration menu
    Copy the full SHA
    fa418af View commit details
    Browse the repository at this point in the history
Loading