You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Difference with node-http-signature regarding (request-target) #5
There is a difference between inclusion of request-target in a signing string.
In joyent implementation they prepend "(request-target): " before value.
In this implementation this is not done.
Thanks, @vonagam. I haven't been keeping up with the evolution of the spec, so I'm not surprised I missed this change. On the other hand, I'm not surprised that this particular change was made, since I noticed that the HTTP protocol version specifier isn't always present or consistent in Java HTTP client/server APIs. I will implement this ASAP.
edit: I take it back. It's been so long that I didn't even remember that I handled the deprecation in another commit.
Activity
adamcin commentedon Mar 6, 2017
Thanks, @vonagam. I haven't been keeping up with the evolution of the spec, so I'm not surprised I missed this change. On the other hand, I'm not surprised that this particular change was made, since I noticed that the HTTP protocol version specifier isn't always present or consistent in Java HTTP client/server APIs. I will implement this ASAP.
edit: I take it back. It's been so long that I didn't even remember that I handled the deprecation in another commit.
adamcin commentedon Mar 7, 2017
Fix included in httpsig-java 1.3.0 release.
vonagam commentedon Mar 7, 2017
Thanks for fast response and your time put into this library.