remove last uses of 'u' prefix#8318
Merged
Merged
Conversation
jepler
reviewed
Aug 22, 2023
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
Thank you! By number of files this was a lot of work. I spotted one mistaken change, though
dhalbert
force-pushed
the
remove-u-prefix
branch
from
4709994 to
24f2f76
Compare
dhalbert
force-pushed
the
remove-u-prefix
branch
from
24f2f76 to
4a62665
Compare
Collaborator
Author
|
@jepler OK, everything passing now except for the docs build, which you fixed and is in the 8.2.x->main merge. |
jepler
approved these changes
Aug 22, 2023
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
The failing doc build should not block merging this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some accidental reversions to
u-prefixes due toMP_REGISTER_MODULE()changes. But some tests still depended onuprefixes. I took the leap of removing all theuprefixes, getting most of the way toward micropython#9069, which does the same thing in MicroPython.import ufoo as foostuff in the tests. This happens in top: Replaceumodulewithmoduleeverywhere. micropython/micropython#9069.timeq/utimeq, which was not used anyway. It is also removed in top: Replaceumodulewithmoduleeverywhere. micropython/micropython#9069.btree,framebufandusocket.extra_coverageauto-complete tests.