Enable -Wmissing-prototypes for atmel-samd - #5561
Merged
Merged
Conversation
jepler
marked this pull request as ready for review
November 10, 2021 03:14
Author
|
The build error on pyruler was a transient Actions problem, it built locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a function is defined, but its declaration isn't present, the compiler can't check that the declaration and definition match. "-Wmissing-prototypes" enables a diagnostic in this case.
Fixes fall into several categories:
This PR aims to fix all the diagnostics that occur in the atmel-samd builds, so that the -Wmissing-prototypes flag can be enabled in that whole port.