Fix Arduino RP2040 flash size#5035
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Jul 21, 2021
Merged
Conversation
For RP2040 boards, we now change the default flash size based on the configured flash. We will still try to read the size from the flash first. Fixes micropython#4874
dhalbert
approved these changes
Jul 21, 2021
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Tested on various Adafruit RP2040 boards, and on Arduino Nano RP2040 Connect. The latter now gets the correct size after doing storage.erase_filesystem().
Will merge after builds complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RP2040 boards, we now change the default flash size based on
the configured flash. We will still try to read the size from the
flash first.
Fixes #4874