Skip to content
This repository was archived by the owner on Feb 9, 2021. It is now read-only.

Add support for TruffleRuby#28

Closed
eregon wants to merge 1 commit into
actions:masterfrom
eregon:truffleruby
Closed

Add support for TruffleRuby#28
eregon wants to merge 1 commit into
actions:masterfrom
eregon:truffleruby

Conversation

@eregon

@eregon eregon commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

See #20

This now works on ubuntu-latest, but not yet on macos-latest:
Ubuntu: https://github.com/eregon/setup-ruby-test/runs/318021757
macOS: https://github.com/eregon/setup-ruby-test/runs/318021775

One thing that is still necessary is recompiling the openssl C extension against the system libssl (done in the post-install hook).

@damccorm How does the tool cache work? It does not seem to persist across runs currently with tc.cacheDir/tc.find. If it did, I think it could avoid having to run the post-install hook on every run.

@eregon eregon marked this pull request as ready for review September 21, 2019 20:22
@eregon eregon force-pushed the truffleruby branch 2 times, most recently from 79480e4 to 69a5246 Compare September 21, 2019 20:33
@eregon

eregon commented Sep 22, 2019

Copy link
Copy Markdown
Contributor Author

This now works on macOS too and is ready for review.
https://github.com/eregon/setup-ruby-test/runs/231525062

@eregon

eregon commented Nov 24, 2019

Copy link
Copy Markdown
Contributor Author

TruffleRuby 19.3.0 has been released, and no longer depends on a system-installed LLVM, which simplifies this quite a bit. The new release also handles macOS not having system headers anymore automatically.

@damccorm Could you review this?

I'd like to add some documentation for this in the README, but I think we should merge #27 first.

@eregon

eregon commented Nov 24, 2019

Copy link
Copy Markdown
Contributor Author

@eregon eregon mentioned this pull request Jan 2, 2020
@pkuczynski

Copy link
Copy Markdown

Any chances to merge this in?

@eregon

eregon commented Jan 4, 2020

Copy link
Copy Markdown
Contributor Author

@bryanmacfarlane Could you review this?

In the meantime, https://github.com/eregon/use-ruby-action supports Ruby, JRuby and TruffleRuby.

@pkuczynski

Copy link
Copy Markdown

@eregon this is not a fork of this repo, isn't it? And it only supports the latest stable versions, right?

@eregon

eregon commented Jan 4, 2020

Copy link
Copy Markdown
Contributor Author

@pkuczynski https://github.com/eregon/use-ruby-action is another action, and currently I think it's a superset of setup-ruby in terms of versions offered. It could probably support more versions if needed.

Anyway, this PR would add TruffleRuby support to setup-ruby, but given the maintainers have been rather inactive I don't know how long it will take to be merged. That other action supports truffleruby currently (and more recent versions), that's why I mentioned it here.

@pkuczynski

Copy link
Copy Markdown

Yeah, I ended up using your package in my build rubyconfig/config#266. Much more up to date. Let's hope it will stay like this :)

@eregon

eregon commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

I'll close this, it's growing conflicts and it probably make little sense to add before this action supports more prebuilt MRI versions.

If someone wants to test with TruffleRuby, JRuby or more Ruby versions, I suggest to use https://github.com/ruby/setup-ruby

@eregon eregon closed this Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants