Add support for TruffleRuby#28
Conversation
79480e4 to
69a5246
Compare
|
This now works on macOS too and is ready for review. |
c4ee063 to
b05ad7a
Compare
|
TruffleRuby 19.3.0 has been released, and no longer depends on a system-installed LLVM, which simplifies this quite a bit. The new release also handles macOS not having system headers anymore automatically. @damccorm Could you review this? I'd like to add some documentation for this in the README, but I think we should merge #27 first. |
|
Working example usage: |
|
Any chances to merge this in? |
|
@bryanmacfarlane Could you review this? In the meantime, https://github.com/eregon/use-ruby-action supports Ruby, JRuby and TruffleRuby. |
|
@eregon this is not a fork of this repo, isn't it? And it only supports the latest stable versions, right? |
|
@pkuczynski https://github.com/eregon/use-ruby-action is another action, and currently I think it's a superset of Anyway, this PR would add TruffleRuby support to |
|
Yeah, I ended up using your package in my build rubyconfig/config#266. Much more up to date. Let's hope it will stay like this :) |
|
I'll close this, it's growing conflicts and it probably make little sense to add before this action supports more prebuilt MRI versions. If someone wants to test with TruffleRuby, JRuby or more Ruby versions, I suggest to use https://github.com/ruby/setup-ruby |
See #20
This now works on
ubuntu-latest, but not yet onmacos-latest:Ubuntu: https://github.com/eregon/setup-ruby-test/runs/318021757
macOS: https://github.com/eregon/setup-ruby-test/runs/318021775
One thing that is still necessary is recompiling the openssl C extension against the system libssl (done in the post-install hook).
@damccorm How does the tool cache work? It does not seem to persist across runs currently with
tc.cacheDir/tc.find. If it did, I think it could avoid having to run the post-install hook on every run.