Skip to content

Reject invalid boolean input values - #1159

Closed
brunoborges with Copilot wants to merge 1 commit into
mainfrom
copilot/reject-invalid-values-boolean-inputs
Closed

brunoborges with Copilot wants to merge 1 commit into
mainfrom
copilot/reject-invalid-values-boolean-inputs

Conversation

Copilot AI commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Description:
Invalid non-empty boolean inputs were silently treated as false, which could disable requested behavior without any signal. This change makes boolean input parsing strict across all affected inputs and fails early with the input name and invalid value.

  • Parsing behavior

    • Accept only true and false for:
      • check-latest
      • force-download
      • set-default
      • verify-signature
      • overwrite-settings
      • show-download-progress
      • problem-matcher
    • Preserve case-insensitive parsing.
    • Trim surrounding whitespace before validation.
    • Continue using the configured default when the input is empty.
  • Validation failure

    • Invalid non-empty values now throw a descriptive error instead of being coerced to false.
  • Test coverage

    • Add unit coverage for valid values, defaults, casing, whitespace, and invalid values for all affected inputs.

Example invalid input now fails fast:

- uses: actions/setup-java@v6
  with:
    distribution: temurin
    java-version: '21'
    verify-signature: ture

Related issue:
Handled automatically by the system.

Check list:

  • Ran npm run check locally (format, lint, build, test) and all checks pass.
  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copilot AI linked an issue Jul 29, 2026 that may be closed by this pull request
5 tasks
Copilot AI changed the title [WIP] Reject invalid values for boolean inputs Reject invalid boolean input values Jul 29, 2026
Copilot AI requested a review from brunoborges July 29, 2026 02:09
@brunoborges
brunoborges marked this pull request as ready for review July 29, 2026 02:14
Copilot AI review requested due to automatic review settings July 29, 2026 02:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject invalid values for boolean inputs

3 participants