Skip to content

There is no AGENT_TOOLSDIRECTORY on GitHub images - #21

Merged
maxim-lobanov merged 1 commit into
actions:masterfrom
mjpieters:no-agentstoolcache-gha
May 5, 2020
Merged

maxim-lobanov merged 1 commit into
actions:masterfrom
mjpieters:no-agentstoolcache-gha

Conversation

@mjpieters

Copy link
Copy Markdown
Contributor

@mjpieters

Copy link
Copy Markdown
Contributor Author

Incidentally: the setup-python README tells us to open issues here in the python-versions repository to request new Python releases:

  • If there is a specific version of Python that is not available, you can open an issue in the python-versions repository.

Yet this repository doesn’t have the issues option enabled. Oversight perhaps?

@konradpabjan

Copy link
Copy Markdown
Contributor

Hello @mjpieters

Apologies for the README discrepancies (I've updated it now). I forgot to update that section, when i removed some other references to creating issues in this repository.

The reason issues are closed in this repo is so that it is easier to maintain and triage. Python issues come in setup-python and virtual-environments so having a third repository to regularly check on would become difficult

@konradpabjan

Copy link
Copy Markdown
Contributor

@maxim-lobanov, @MaksimZhukov could you take a look at this small code change?

@maxim-lobanov

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maxim-lobanov

Copy link
Copy Markdown
Contributor

Hello @mjpieters, your changes LGTM. We didn't do these changes initially because Hosted Ubuntu images have AGENT_TOOLSDIRECTORY as far as I know. But your fix is important to support self-hosted agents properly.

Currently, CI fails on your changes because of the way that we use to generate installer scripts. I have improved it in scope of #22 . Could you please pull latest master to your branch and I will rerun CI?

@mjpieters

mjpieters commented May 5, 2020 •

Copy link
Copy Markdown
Contributor Author

@MaksimZhukov I rebased and force-pushed, I suspect that now means you have to run the pipeline manually. GitHub doesn't think there is a need for any checks, at any rate.

@mjpieters

mjpieters commented May 5, 2020 •

Copy link
Copy Markdown
Contributor Author

Nope, I don't have permission to do this myself. :-)

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 21 in repo actions/python-versions

@maxim-lobanov

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maxim-lobanov

Copy link
Copy Markdown
Contributor

@mjpieters

Copy link
Copy Markdown
Contributor Author

Looks like the manual build completed successfully.

@maxim-lobanov
maxim-lobanov merged commit f75c0e6 into actions:master May 5, 2020
@maxim-lobanov

Copy link
Copy Markdown
Contributor

@mjpieters , merged. I will re-upload existing versions with this fix.

@mjpieters
mjpieters deleted the no-agentstoolcache-gha branch May 5, 2020 11:36
@maxim-lobanov

Copy link
Copy Markdown
Contributor

All versions were regenerated and re-uploaded with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants