Repository navigation
fix: setup OpenSSL certificates in macos-pkg-setup-template.sh - #189
Merged
Merged
Conversation
The macOS pkg installer does not setup default certificates for OpenSSL. A script is provided by the macOS pkg installer to setup those using the certifi PyPI package. Let's run this script as part of the setup template in order to be able to do HTTPS downloads out of the box.
3 of 6 tasks
Contributor
Author
|
PS: I checked that without this fix, the added test would fail: https://github.com/mayeut/python-versions/actions/runs/3164018493 |
vsafonkin
approved these changes
Oct 3, 2022
marko-zivic-93
approved these changes
Oct 3, 2022
dmitry-shibanov
approved these changes
Oct 3, 2022
|
@mayeut thank you for your help! |
neersighted
pushed a commit
to python-poetry/poetry
that referenced
this pull request
Oct 3, 2022
actions/setup-python#512 has been fixed by actions/python-versions#189, so the workaround is no longer necessary.
This was referenced Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS pkg installer does not setup default certificates for OpenSSL.
A script is provided by the macOS pkg installer to setup those using the certifi PyPI package.
Let's run this script as part of the setup template in order to be able to do HTTPS downloads out of the box.
fixes actions/setup-python#512