You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replace most method overloads of writeData and writeIntoBuffer with a UZKFileInfo instance #89
There are far too many overloads of the -writeData:... and -writeInfoBuffer:... methods, which causes friction, complexity, and unnecessary bugs (e.g. #81, #85) due to incorrect and/or inconsistent values being passed as defaults from the shorter overloads.
Instead, add public initializers to UZKFileInfo, and update the most complicated overload to take that as the only argument, reading the required properties out of it. There should still be one more overload for each, covering the simplest case of only a file path and the data being written.
The PR, as written, went in a different direction, keeping UZKFileInfo a class that's read-only to API consumers, and introducing a new ZipFileProperties class (written in Swift), which can be modified and passed to the new overloads of -writeData:... and -writeIntoBuffer:....
Activity
abbeycode commentedon Aug 20, 2019
The PR, as written, went in a different direction, keeping UZKFileInfo a class that's read-only to API consumers, and introducing a new ZipFileProperties class (written in Swift), which can be modified and passed to the new overloads of
-writeData:...and-writeIntoBuffer:....Updated changelog and readme for issue #89