Skip to content

Replace most method overloads of writeData and writeIntoBuffer with a UZKFileInfo instance #89

Closed

Description

@abbeycode

There are far too many overloads of the -writeData:... and -writeInfoBuffer:... methods, which causes friction, complexity, and unnecessary bugs (e.g. #81, #85) due to incorrect and/or inconsistent values being passed as defaults from the shorter overloads.

Instead, add public initializers to UZKFileInfo, and update the most complicated overload to take that as the only argument, reading the required properties out of it. There should still be one more overload for each, covering the simplest case of only a file path and the data being written.

Activity

  1. added this to the v2.0 milestone on Jul 2, 2019
  2. self-assigned this
    on Jul 2, 2019
  3. abbeycode commented on Aug 20, 2019

    @abbeycode
    OwnerAuthor

    The PR, as written, went in a different direction, keeping UZKFileInfo a class that's read-only to API consumers, and introducing a new ZipFileProperties class (written in Swift), which can be modified and passed to the new overloads of -writeData:... and -writeIntoBuffer:....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions