Skip to content

Compile with -Weverything flag #68

Closed

Description

@abbeycode

This produces a ton of warnings, but the problem is I don't want any warnings reported for the minizip library. I can solve this by moving the minizip library into its own static library that'll get compiled in. Then I'll specify -Weverything for UnzipKit, and -Wnone for minizip. This was implemented in abbeycode/UnrarKit#56

  • Split minizip into its own library, linked into UnzipKit
  • Specify -Weverything for UnrarKit
  • Fix all warnings produced

Activity

  1. abbeycode commented on Oct 15, 2017

    @abbeycode
    OwnerAuthor

    Turns out -Weverything was already turned on, but it was configured differently for debug and release configurations, and the minizip warnings were being ignored globally. So this turned into a simplification of the warning configuration.

  2. added this to the 1.9 milestone on Oct 15, 2017
  3. self-assigned this
    on Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions