You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Empty directories are duplicated when deleted and added again #55
Thanks for reporting this. Can you please take a look at the issue template I created and copy/paste into your issue? I could use the additional info requested there to figure out what's going on for you. I'm going to paste this into Issue #56 also.
Steps to reproduce:
1- Add a file to zip with writeData:filePath:progress:error:
2- Delete file using deleteFile:error:
3- Readd same file using step 1
4- List files using listFileInfo:
Result of step 4 contains file 2 times.
I can send testflight invitation of my app to check in beta version
I've pushed a test case into a branch that follows the code you described, but with correct results. Can you please update the test case so it fails in the way you're expecting?
Finally I found the problem.
1- create an empty folder, not file, using the code I made a pull request.
2- delete that folder
3- create an empty folder with same name again
I think the problem occurs when data is empty, instance of [NSData data].
I created a test case again (this time it happens to be in Swift because the file with other writeData tests is in Swift. The test case is passing for me. Can you take a look again and see if we can modify it so it demonstrates your issue?
I just updated the emptydir branch so the test case I wrote is on the latest v2.0 branch. Do you have any time to modify that test case to reproduce your issue in a PR?
@amosavian I'm going to close this, since I haven't heard back from you in a while. Please feel free to reopen if you'd like to work with me on this at some point.
Activity
abbeycode commentedon Apr 21, 2017
Thanks for reporting this. Can you please take a look at the issue template I created and copy/paste into your issue? I could use the additional info requested there to figure out what's going on for you. I'm going to paste this into Issue #56 also.
amosavian commentedon Apr 22, 2017
Steps to reproduce:
1- Add a file to zip with
writeData:filePath:progress:error:2- Delete file using
deleteFile:error:3- Readd same file using step 1
4- List files using
listFileInfo:Result of step 4 contains file 2 times.
I can send testflight invitation of my app to check in beta version
Added test case to attempt to reproduce Issue #55 (but it's passing, …
abbeycode commentedon Apr 24, 2017
I've pushed a test case into a branch that follows the code you described, but with correct results. Can you please update the test case so it fails in the way you're expecting?
amosavian commentedon Apr 24, 2017
Weird because I got it fixed now! or I may don't remember exact steps.
Thanks
amosavian commentedon Apr 25, 2017
Finally I found the problem.
1- create an empty folder, not file, using the code I made a pull request.
2- delete that folder
3- create an empty folder with same name again
I think the problem occurs when data is empty, instance of
[NSData data].abbeycode commentedon Aug 8, 2017
Is this something you're still working on?
abbeycode commentedon Oct 7, 2017
@amosavian I'm going through open issues now, so you'll see me replying to a bunch of them. Sorry to hit you all at once :)
Are you still taking a look at this, or should I close it out?
amosavian commentedon Oct 7, 2017
This problem still exists. This only occurs when I create folder in zip, not a regular file.
abbeycode commentedon Oct 7, 2017
So steps to reproduce are the following?
[NSData data])And then what happens at that point? Is an
NSErrorreturned?amosavian commentedon Oct 7, 2017
No, when I list archive files at then end, I get entry twice. Indeed deleted directory revives somehow.
Added test case for issue #55 [CI skip]
abbeycode commentedon Oct 11, 2017
I created a test case again (this time it happens to be in Swift because the file with other
writeDatatests is in Swift. The test case is passing for me. Can you take a look again and see if we can modify it so it demonstrates your issue?4 remaining items
Added test case for issue #55 [CI skip]
Added test case for issue #55 [CI skip]
Added test case for issue #55 [CI skip]
abbeycode commentedon Oct 20, 2017
@amosavian Have you had a chance to look at the test case I set up?
amosavian commentedon Oct 21, 2017
I did
abbeycode commentedon Oct 22, 2017
I pushed an update with the trailing slash, and the case still passes
Added test case for issue #55 [CI skip]
Added test case for issue #55 [CI skip]
abbeycode commentedon Jul 2, 2019
I just updated the
emptydirbranch so the test case I wrote is on the latest v2.0 branch. Do you have any time to modify that test case to reproduce your issue in a PR?Added test case for issue #55 [CI skip]
Added test case for issue #55 [CI skip]
abbeycode commentedon Aug 1, 2019
@amosavian I'm going to close this, since I haven't heard back from you in a while. Please feel free to reopen if you'd like to work with me on this at some point.