Skip to content

Framework Issues #48

Closed
Closed

Description

@amosavian

Hi,

I wanted to add framework for dynamic linking to my project, it doesn't show iOS framework in Embedded Binaries and even when I fixed it, I had issues for resources.bundle file.

Interestingly, I had not these issues with UnrarKit, while I get UnrarKit/Classes/UnrarKit.h:12:9: 'Cocoa/Cocoa.h' file not found error.

Activity

  1. abbeycode commented on Dec 5, 2016

    @abbeycode
    Owner

    It's complaining about not finding Cocoa.h since that's a Mac header. For cross-platform projects I usually ifdef Cocoa for Mac and UIKit for iOS. From UnrarKit:

    #if TARGET_OS_IPHONE
    #import <UIKit/UIKit.h>
    #else
    #import <Cocoa/Cocoa.h>
    #endif
  2. abbeycode commented on Dec 9, 2016

    @abbeycode
    Owner

    Are you still having this problem?

  3. amosavian commented on Dec 9, 2016

    @amosavian
    ContributorAuthor

    I didn't try again. Falled back to manual inclusion. I'll try and inform you

  4. amosavian commented on Dec 11, 2016

    @amosavian
    ContributorAuthor

    @abbeycode I solved the problem with UnrarKit by adding new line to UnrarKit.h umbrella header:

    #import <TargetConditionals.h> //  <-- THIS LINE ADDED
    
    #if TARGET_OS_IPHONE
    #import <UIKit/UIKit.h>
    #else
    #import <Cocoa/Cocoa.h>
    #endif

    I will tell about UnzipKit if I overcome the problem

  5. amosavian commented on Dec 12, 2016

    @amosavian
    ContributorAuthor

    I got this error when tried to upload to iTunesConnect, using UnrarKit.framework in project:

    ERROR ITMS-90060: "This bundle is invalid. The value for key CFBundleShortVersionString '2.8-beta' in the Info.plist file must be a period-separated list of at most three non-negative integers."
    

    There is also some other malformations in framework 😂 but as far as it works there is no problem.

  6. abbeycode commented on Dec 12, 2016

    @abbeycode
    Owner

    Interesting. If you're working off of a fork, just update the Info.plist not to be a beta (just 2.8).

  7. amosavian commented on Dec 12, 2016

    @amosavian
    ContributorAuthor

    I did and now is uploading the binary \o/

  8. abbeycode commented on Dec 12, 2016

    @abbeycode
    Owner

    How are you producing the framework? Are you using Carthage?

  9. amosavian commented on Dec 12, 2016

    @amosavian
    ContributorAuthor

    Nope, simply dragged .xcodeproj into my project and added it to Embedded Binary section.
    Carthage automatically rectifies some common malformations and universal binaries. But I'm more convenient with this style

  10. abbeycode commented on Dec 27, 2016

    @abbeycode
    Owner

    I was reading back through this thread, and I couldn't tell if UnzipKit is being affected, or if this only affected UnrarKit. Is there any work left to do on UnzipKit related to using it as a dynamic framework?

  11. amosavian commented on Dec 28, 2016

    @amosavian
    ContributorAuthor

    I didn't tried to figure out how to resolve the problem with UnzipKit yet, I'll try after new year eve.

  12. amosavian commented on Dec 30, 2016

    @amosavian
    ContributorAuthor

    I tried UnzipKit framework again, now the problem is UnzipKit-iOS target is not enlisted in Embedded Binaries section in project settings when I want to add it while I can see UnzipKit macOS in the list. I tried to solve problem by changing some project settings without success.
    I supposedly has to recreate iOS target from scratch.

  13. added this to the 1.8.3 milestone on Jan 5, 2017
  14. abbeycode commented on Jan 5, 2017

    @abbeycode
    Owner

    Can you try the issue48 branch? I think it should work for you now. If so, I'll cut a new release.

  15. amosavian commented on Jan 6, 2017

    @amosavian
    ContributorAuthor

    @abbeycode tested and it works perfectly

  16. abbeycode commented on Jan 11, 2017

    @abbeycode
    Owner

    This has been merged to master and is included in v1.8.3. Thanks again for pointing it out!

  17. amosavian commented on Jan 12, 2017

    @amosavian
    ContributorAuthor

    Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions