Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aadsm/JavaScript-ID3-Reader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: aadsm/JavaScript-ID3-Reader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: gh-13_readAsBinaryString
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Nov 10, 2013

  1. Add ArrayBuffer support to BinaryFile

    @aadsm
    aadsm committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    1a1124d View commit details
    Browse the repository at this point in the history

  2. Use readAsArrayBuffer instead of readAsBinaryString 

    IE10 doesn't implement readAsBinaryString and it has been deprecated from the FileReader API so we need to use readAsArrayBuffer.
    @aadsm
    aadsm committed Nov 10, 2013
    Configuration menu
    Copy the full SHA
    7ee6562 View commit details
    Browse the repository at this point in the history
Loading