Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Accept and ignore unknown kwargs #4

Merged
sorenisanerd merged 2 commits into from
Dec 29, 2015
Merged

Accept and ignore unknown kwargs #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3f8d3
Accept and ignore unknown kwargs
pljensen Dec 29, 2015
50e0689
Add documentation
pljensen Dec 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dbuild/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def docker_build(build_dir, build_type, source_dir='source', force_rm=False,
docker_url='unix://var/run/docker.sock', dist='ubuntu',
release='trusty', extra_repos_file='repos',
extra_repo_keys_file='keys', build_cache=True, proxy="",
build_owner=None):
build_owner=None, **kwargs):

@sorenisanerd sorenisanerd Dec 29, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a quick note to the documentation about this? All the other args are documented.

"""
build_dir: build directory, this directory will be mounted to /build in
container
Expand All @@ -117,6 +117,7 @@ def docker_build(build_dir, build_type, source_dir='source', force_rm=False,
proxy: value of proxy to be passed when used behind proxy settings
otherwise it will be default empty
build_owner: user id which will own all build files
kwargs: dict of unknown arguments. Ignored. For forward compatibility.
"""

command = ''
Expand Down