Skip to content

A new approach to the Python#5

Closed
KeynesYouDigIt wants to merge 4 commits into
aWhereAPI:masterfrom
KeynesYouDigIt:master
Closed

A new approach to the Python#5
KeynesYouDigIt wants to merge 4 commits into
aWhereAPI:masterfrom
KeynesYouDigIt:master

Conversation

@KeynesYouDigIt

Copy link
Copy Markdown

This pull does a bunch of different things, the central piece being replacing httplib calls with calls from requests, which is currently one of the most dominant and useful libraries in the entire ecosystem.

See-
http://pypi-ranking.info/alltime

http://stackoverflow.com/questions/2018026/what-are-the-differences-between-the-urllib-urllib2-and-requests-module

Second, this version of the python example is directed at producing calls and printing the full result rather than a command line tool for looking at data - the original python scripts came across more as the later. Taking code and incorporating into your app is thus much more natural

To test the example code, simply run >python {script of interest}

This pull requests also eliminates a plethora of redundancies, and is robustly tested. I was not able to make the old scripts work. I do have the httplib calls preserved in the /older versions directory, feel free to move all the old python code there or preserve elsewhere before pulling this new code in, just incase there is something wrong with it that is discovered later.

Let me know what you think and if it can be improved. Thanks!

I will hopefully be using this to plug the data into some of my own projects soon, and perhaps build a flask API for exploring the data in the API (that might be s/w redundant given postman)

@KeynesYouDigIt

Copy link
Copy Markdown
Author

Any word on this guy? feedback/suggestions?

@sesteel sesteel closed this Apr 5, 2017
@KeynesYouDigIt

Copy link
Copy Markdown
Author

no luck? any feedback?

@sesteel

sesteel commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

We value contributions to our GitHub repositories and thank you for taking the time to make a pull request. Unfortunately, we can't accept this request and have closed it for non-technical reasons.

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants