Repository navigation
ci: Add extras to unit-tests.yml install to prevent dependency issues - #920
holtskinner wants to merge 2 commits into
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
🧪 Code Coverage (vs
|
ishymko
left a comment
There was a problem hiding this comment.
I've tried to run uv run --all-extras pytest on #918 (broken actions run reference) and it failed with the same error:
ImportError while importing test module '/usr/local/google/home/ishymko/src/a2a-python.review/tests/contrib/tasks/test_vertex_task_store.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
src/a2a/contrib/tasks/vertex_task_store.py:8: in <module>
from vertexai import types as vertexai_types
E ImportError: cannot import name 'types' from 'vertexai' (/usr/local/google/home/ishymko/src/a2a-python.review/.venv/lib/python3.10/site-packages/vertexai/__init__.py)
The above exception was the direct cause of the following exception:
../../.local/share/uv/python/cpython-3.10.18-linux-x86_64-gnu/lib/python3.10/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/contrib/tasks/test_vertex_task_store.py:63: in <module>
from a2a.contrib.tasks.vertex_task_store import VertexTaskStore
src/a2a/contrib/tasks/vertex_task_store.py:10: in <module>
raise ImportError(
E ImportError: VertexTaskStore requires vertexai. Install with: 'pip install a2a-sdk[vertex]'
which is coming from google-cloud-aiplatform upgrade in that PR, there is some upstream bug:
$ uv run python -c "import importlib; importlib.import_module('vertexai._genai.types')"
AttributeError: module 'google.genai.types' has no attribute 'BigQuerySource'
It requires upgrading google-genai as well, seems like dependencies are not specified properly in google-cloud-aiplatform.
I am going to patch that dependabot PR.
|
I reported it in googleapis/python-aiplatform#6536 |
Thanks for patching the dependabot PR. I don't think this one will be needed now. |
Should fix dependency issue from Actions https://github.com/a2aproject/a2a-python/actions/runs/23836824689/job/69482510119?pr=918