Repository navigation
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/cluster/database_event_stream.py | 97.27% | 93.64% | 🔴 -3.64% |
| Total | 93.67% | 93.63% | 🔴 -0.03% |
Generated by coverage-comment.yml
miinimal
marked this pull request as ready for review
November 13, 2026 23:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
validate_input_modes=True, a card that declares a media range such asimage/*rejected every concrete image type, because the validator comparedtype/subtypeliterally. This was the question left open in #1425, and it breaks cards built by other SDKs: Microsoft Agent Framework's A2A hosting adapter documentsimage/*modes and returns a nativeAgentCardfor use with this SDK's handlers, so the same card acceptsimage/pngthere and rejects it here (reproduction in #1468).A declared
type/*now matches any part of that type, and*/*matches any part (RFC 9110 section 12.5.1). Everything from #1425 stays: case-insensitive, parameters ignored, parts withoutmedia_typeunchecked. Exact declarations behave as before, andimage/*still rejectsvideo/mp4.The full local run was on Windows, where 4 failures and 8 errors in
tests/integration/(cross-version client/server, push notifications, samples smoke) also happen on unmodified main; they start subprocess servers and are unrelated to this change. CI covers them on Linux.AI assistance: the analysis, the change and the tests were prepared with an AI coding assistant; I reviewed the diff and ran the checks above.
CONTRIBUTINGGuide.bash scripts/format.shfrom the repository root to format)validate_input_modesdocstring now states how media ranges match.Fixes #1468 🦕