Repository navigation
fix(compat): send no v0.3 configuration when the request has none - #1429
Merged
Iwaniukooo11 merged 3 commits intoNov 12, 2026
Merged
Conversation
The v0.3 REST and gRPC client transports sent an empty SendMessageConfiguration for a request without one. v0.3 `blocking` has no presence, so the server read it as blocking=false and returned the task as soon as it was submitted. The v0.3 JSON-RPC transport omits the configuration and gets the blocking default; do the same.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/compat/v0_3/proto_utils.py | 90.76% | 91.13% | 🟢 +0.37% |
| src/a2a/server/cluster/database_event_stream.py | 92.73% | 97.27% | 🟢 +4.55% |
| Total | 93.49% | 93.55% | 🟢 +0.07% |
Generated by coverage-comment.yml
Iwaniukooo11
requested changes
Nov 10, 2026
Contributor
Author
|
Thank you this was helpful. Updated the code to include the gRPC check, added the assertion to test_none_handling and cut the docstring to one line. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.3 REST and gRPC client transports sent an empty
SendMessageConfigurationfor a request without one, which the server reads asblocking=false.Fix
ToProto.message_send_configurationreturnsNonewhen there is no configuration, so the client sends none and the server keeps its blocking default, like the JSON-RPC transport.Tests
test_compat_rest_transport_send_message_without_configurationandtest_compat_grpc_transport_send_message_without_configurationfail on main.test_compat_rest_transport_send_message_with_configurationchecks that an explicit configuration still sendsblocking: true. 2555 passed.Fixes #1428