Skip to content

fix: skip hidden directories in BOM verifier class discovery - #984

Merged
kabir merged 1 commit into
a2aproject:mainfrom
kabir:ignore-claude-boms
Jul 20, 2026
Merged

kabir merged 1 commit into
a2aproject:mainfrom
kabir:ignore-claude-boms

Conversation

@kabir

@kabir kabir commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Files.walk traverses into .claude/worktrees/ which contains full repo copies, causing the same classes to appear in both the required and forbidden sets. Skip any path starting with "." to avoid scanning hidden directories like .claude/, .git/, etc.

Files.walk traverses into .claude/worktrees/ which contains full repo
copies, causing the same classes to appear in both the required and
forbidden sets. Skip any path starting with "." to avoid scanning
hidden directories like .claude/, .git/, etc.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the class discovery logic in DynamicBomVerifier.java to ignore hidden files and directories by checking if the relative path starts with a dot. The review feedback points out that this check only works for root-level hidden directories and suggests a more robust check to exclude nested hidden directories at any depth.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kabir
kabir merged commit 529228a into a2aproject:main Jul 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant