Repository navigation
feat: support authentication field in push notification webhooks - #851
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for HTTP Authorization headers in push notifications by integrating PushNotificationAuthenticationInfo into the dispatch process. Corresponding unit tests were added to verify various authentication scenarios. Feedback was provided to simplify the authentication check by removing a redundant null check and adding a blankness check for credentials to prevent malformed headers.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
jmesnil
approved these changes
May 6, 2026
Contributor
|
@kabir thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this wasn't getting propagated when working on a2aproject/a2a-tck#178