Repository navigation
fix: normalize compat transport error responses - #1305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align unexpected-error responses in the v0.3 compatibility transports with the v1.0 behavior. JSON-RPC, REST, and gRPC return a consistent
Internal errormessage and log the underlying exception on the server, while preserving explicit protocol errors.Update transport and reference-route tests, and add a live multiversion JSON-RPC test covering both v0.3 and v1.0.
Validation:
mvn -B -pl compat-0.3/transport/grpc,compat-0.3/transport/jsonrpc,compat-0.3/transport/rest,compat-0.3/reference/jsonrpc,compat-0.3/reference/rest,tests/multiversion/jsonrpc -am test