Repository navigation
fix: handle large SSE events in Vert.x HTTP client - #1304
Merged
Merged
Conversation
Parse response buffers incrementally with the shared SSE parser and enforce the default line and event limits. Preserve framing across UTF-8 and line-ending boundaries, recover after oversized events, and complete futures when callbacks fail. Add coverage for fragmented GET and POST streams, parser limits, and callback failures.
Collaborator
Author
|
Fixed #1304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vert.x HTTP client can stop reading when an SSE event exceeds the codec's 4 KiB buffer watermark, leaving the stream unfinished. Parse response buffers incrementally with the shared SSE parser so large events are delivered and streams complete.
Apply the default line and event limits, preserve UTF-8 and line framing across buffers, and recover after oversized events. Add regression coverage for fragmented GET and POST streams, parser limits, and callback exceptions, and document the Vert.x parser limits.
Validation:
mvn -pl extras/http-client-vertx -am test -DskipTests=falsepassed.