Repository navigation
fix: avoid loading peer-supplied exception classes - #1296
Merged
kabir merged 1 commit intoNov 5, 2026
Merged
Conversation
Use a generic exception when reading v0.3 JSON-RPC error data. Add regression coverage for class initialization and constructor invocation. Based on a fix and test proposed by Chaitanya Pawar.
Chaitanya-Pawar8
approved these changes
Nov 5, 2026
Chaitanya-Pawar8
left a comment
Chaitanya-Pawar8
left a comment
There was a problem hiding this comment.
LGTM — the fix correctly removes Class.forName from the read path. The two regression tests (non-Throwable init + Throwable instantiation) are clean and comprehensive. The Javadoc update is accurate.
Thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.3 JSON-RPC error deserializer loads the class named in error data and may invoke its constructor. Return a generic
RuntimeExceptionwith the supplied message instead, while keeping the serialized format unchanged. This changes the Java exception subtype callers see in error data.Add regression tests covering class initialization and exception construction. Based on a fix proposed by Chaitanya Pawar.
Testing
mvn -pl compat-0.3/client/transport/jsonrpc -am test