Repository navigation
ci: restore working CI for the 0.3.x branch - #1274
Merged
Merged
Conversation
Scope the push/pull_request triggers of the workflows living in the 0.3.x tree to the 0.3.x branch only, so maintenance-branch CI no longer fires for unrelated branches. Workflow definitions on main are not affected: push/pull_request runs always load workflows from the event's own ref, and the only default-branch listener (build-with-release-profile-run.yml) already allowlists 0.3.x.
The TCK pyproject only declares requires-python >=3.8.1, so python-version-file resolves to the latest Python (3.15), whose PyO3-based dependencies (cachebox via deepdiff) fail to build. Pin 3.13 explicitly until the TCK declares an upper bound.
The replication integration tests boot Quarkus Dev Services (Redpanda
via Testcontainers). On current GitHub runners (Docker 29.x) the
Testcontainers client of the Quarkus 3.28.x stack cannot detect the
Docker daemon ('Could not find a valid Docker environment'), so
build-and-test always fails there. main runs these tests on a newer
Quarkus/Testcontainers stack.
Add a skipDockerTests surefire switch to the two replication test
modules (default false, mirroring the flag name used on main) and
enable it in build-and-test.yml. The tests still run locally and
wherever a compatible Docker/Testcontainers combination is available.
An explicit <skipTests> surefire configuration would shadow the standard -DskipTests user property, breaking workflows like run-tck and cloud-deployment-example that rely on it. Alias the skipTests property to skipDockerTests in the module properties instead, so both -DskipDockerTests=true and -DskipTests=true skip the docker-dependent tests.
4 tasks done
Collaborator
|
Thanks @Evader-lgb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #1256, this gets the 0.3.x CI into a working state, as discussed.
Verified end-to-end in my fork at commit
31241f02— all four workflows green (Build and Test, Run TCK, Cloud Deployment, Conventional Commits):1. Scope workflow triggers to the 0.3.x branch (build-and-test, run-tck, cloud-deployment-example, build-with-release-profile, conventional-commits). Push/pull_request runs always load workflows from the event's own ref, so main needs no changes; the only default-branch listener (build-with-release-profile-run.yml) already allowlists 0.3.x.
2. run-tck: pin Python 3.13. The TCK pyproject declares
requires-python >=3.8.1with no upper bound, sopython-version-fileresolved to 3.15, where the PyO3-based deps (cachebox via deepdiff) fail to build. With 3.13 pinned, the TCK runs end-to-end and passes on JDK 17/21/25.3. build-and-test: skip docker-dependent replication tests on CI via
-DskipDockerTests=true(the flag build-and-test.yml on main already references; wired here with a property alias so plain-DskipTestskeeps working). These tests boot Quarkus Dev Services (Redpanda via Testcontainers); on current ubuntu-latest runners (Docker 29.x, API minimum 1.40) the Testcontainers client of the Quarkus 3.28.x stack cannot detect the Docker daemon — even though Docker itself works (the Kind-based cloud-deployment job passes on the same image). main runs these tests on the newer Quarkus stack. They still run locally wherever Docker is available.Not touched, per your notes: release-please.yml and release-to-maven-central.yml (tag-driven deploys stay as-is; worst case a 0.3.x release can be deployed manually).
Happy to rework any part — e.g. if you'd rather fix the Testcontainers/Docker 29 detection instead of skipping the docker tests, I can keep digging.