Repository navigation
feat(http-client)!: unify configuration and redirect handling - #1255
Merged
Merged
Conversation
- Configure provider selection, SSE limits, and redirect headers centrally. - Apply one-hop POST redirects consistently across HTTP implementations. Signed-off-by: Emmanuel Hugonnet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP client provider selection, SSE parser limits, and redirect settings are currently configured through separate entry points. Introduce
A2AHttpClientConfigurationto configure them together, and select only providers that support the requested settings. Existing factory overloads remain available and are deprecated in favor of the configuration API.Apply a shared
RedirectHeaderPolicyto explicitly enabled, one-hop synchronous POST redirects across the JDK, Vert.x, and Android implementations. Update transport configuration, client creation, documentation, and tests to use the common configuration.Behavior changes: injected JDK clients must use
HttpClient.Redirect.NEVERwhen enabling SDK-managed POST redirects. Providers that cannot honor explicitly configured SSE limits are skipped instead of falling back to one that ignores them.