Repository navigation
fix(grpc): preserve explicit JSON nulls in value mappings - #1174
Merged
Merged
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks @girishkvs |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve explicit JSON
nullvalues when converting protobuf structured data and metadata.Fixes #1159.
Fixes #1160.
Reports: @lyingparachute and @RemigiuszDudek.
Changes
A2ACommonFieldMapper.javaHashMapinstead of using the null-hostile collector, keeping keys with null values. Convert outbound Java nulls to protobufNULL_VALUEinstead of leaving the value kind unset.A2ACommonFieldMapperTest.java,JSONRPCUtilsTest.java,ToProtoTest.javaExisting absent/empty-Struct and metadata defaults are preserved. No constructor, collection-helper, dependency, or generated-source changes.
Validation
mvn -B -ntp -pl spec-grpc -am clean package.common,spec,jsonrpc-common, andspec-grpcreactor.git diff --check.The full repository, other JDK versions, and transport/TCK suites were not run locally.