Repository navigation
fix(jsonrpc): reject Part with multiple populated content keys - #1065
Merged
Merged
Conversation
Part is a oneOf in the A2A spec, so having more than one populated content key (e.g. both "text" and "data" with non-empty values) is ambiguous and invalid. Previously this was silently accepted, picking whichever key appeared first in document order. Now throws JsonSyntaxException when multiple populated content keys are present. Empty-string placeholders (from protobuf serializers) are still tolerated as before. This fixes a2aproject#1062 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Kabir Khan <[email protected]>
ehsavoie
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The deserializer silently accepted a Part with e.g. both
"text": "hello"and"data": {"answer": "42"}populated, picking whichever key appeared first in document order. This hid malformed input that violates the spec's oneOf constraint.Validation
PartSerializationTesttests pass, including the newtestMultiplePopulatedContentKeysAreRejectedThis fixes #1062
🤖 Generated with Claude Code