Repository navigation
Гонка Ле-Мана-Это мой первый pull request для практической работы - #1
Open
ZarinaLebedeva wants to merge 1 commit into
Open
ZarinaLebedeva wants to merge 1 commit into
ZarinaLebedeva wants to merge 1 commit into
Conversation
Comment on lines
+2
to
+4
| public String name; | ||
| public int speed; | ||
|
|
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
| System.out.println("Введите скорость машины № " + i + ":"); | ||
| if (scanner.hasNextInt()) { | ||
| speed = scanner.nextInt(); | ||
| if (speed > 0 && speed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
Comment on lines
+2
to
+3
| String nameOfLeader = ""; | ||
| int currentLeaderDistance = 0; |
There was a problem hiding this comment.
Обе переменные лучше сделать приватными, чтобы снаружи класса нельзя было сломать его поведение, а для получения имени победителя - написать отдельную функцию-геттер
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Я создала этот pull request для прохождения своей первой проверки практической работы "Гонка 24 часа Ле-мана".