Repository navigation
Conversation
Takexito
reviewed
Jan 16, 2023
|
|
||
| //Метод getNumberOfPeople() запрашивает ввод с консоли значения и помещает его в calculator.numberOfPeople, | ||
| // если значение меньше 1 или не является целым числом, то запрашивает повторно. | ||
| public static void getNumberOfPeople(Calculator calculator) { |
There was a problem hiding this comment.
Лучше не использовать статические методы без необходимости. В данном случае можно было сделать метод не статическим, а внутри статического метода main создать экземпляр класса Main, по аналогии с классом Calculator, и уже у него вызвать методы
|
|
||
| // Метод addNewProductName() запрашивает ввод названия товара и добавляет его в калькулятор | ||
| public static void addNewProductName(Calculator calculator) { | ||
| Scanner sc = new Scanner(System.in); |
There was a problem hiding this comment.
scanner можно вынести в тело класса, и там объявить его один раз, а внутри методов уже использовать это поле,
тем самым не придется в каждом методе создавать новый экземпляр Scanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.