Repository navigation
Проектная работа 1 - #85
Open
Usynin1994 wants to merge 1 commit into
Open
Usynin1994 wants to merge 1 commit into
Usynin1994 wants to merge 1 commit into
Conversation
| } else { | ||
| food = food + name + "\n"; | ||
| System.out.println("Введите цену в формате \"Рубли,Копейки\""); | ||
| float coast = scanner.nextFloat(); |
There was a problem hiding this comment.
Пользователь может ввести на вопрос про стоимость товара вместо числа строку, и приложение упадет. Для количества человек ты обрабатываешь такую ситуацию через hasNextInt, стоит добавить обработку и для стоимости, чтобы приложение не падало
| private String getRightWord (float n) { | ||
| n = (int) Math.floor(n); | ||
| n = Math.abs(n) % 100; | ||
| int n1 = (int) (n % 10); |
There was a problem hiding this comment.
Лучше здесь дать более понятные имена, например, lastDigit
| if (n > 10 && n < 20) return "рублей"; | ||
| if (n1 > 1 && n1 < 5) return "рубля"; | ||
| if (n1 == 1) return "рубль"; | ||
| return "рублей"; |
There was a problem hiding this comment.
Хорошо написанная функция, мало вложенности, за счёт этого легче читать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.