Repository navigation
my 1st request - #72
Closed
kamberbattch wants to merge 3 commits into
Closed
kamberbattch wants to merge 3 commits into
kamberbattch wants to merge 3 commits into
Conversation
faritowich
reviewed
Oct 12, 2022
| // ваш код начнется здесь | ||
| // вы не должны ограничиваться только классом Main и можете создавать свои классы по необходимости | ||
| System.out.println("Привет Мир"); | ||
| Calculator calc = new Calculator(); |
There was a problem hiding this comment.
Можно сделать методы и поля класса Calculator static, чтобы не приходилось создавать экземпляр класса. Тогда можно будет просто вызывать методы: Calculator.inputPersons(); и т.д.
faritowich
reviewed
Oct 13, 2022
| String answer = scan.next(); | ||
| if (answer.equalsIgnoreCase("n")) { | ||
| continue; | ||
| } else {break;} |
There was a problem hiding this comment.
В данном случае continue не нужно, потому что это последняя строчка кода в цикле и он и так начнет цикл с самого начала, даже если continue не будет
| int ruble = (int) Math.floor(totalPrice); | ||
| int payPeople = (int) Math.floor(totalPrice/persons); | ||
| System.out.println("Вы заказали следующие продукты:\n" + names + "на сумму: " + totalPrice + " " + Calculator.payPeoples(ruble)); | ||
| System.out.println("Каждый из " + persons + " человек заплатит по " + String.format("%.2f", totalPrice/persons) + " " + Calculator.payPeoples(payPeople)); |
There was a problem hiding this comment.
Лучше объединить два идущих подряд println в один
| } else { | ||
| System.out.println("Amount of persons must be integer > 1. Try again."); | ||
| scan.nextLine(); | ||
| continue; |
There was a problem hiding this comment.
continue не нужен, потому что это и так последняя строчка кода в цикле
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi