Repository navigation
Conversation
| double allPrice; | ||
| //Сохранение названия товаров и общей стоимости заказа | ||
| void addProduct(Product product){ | ||
| allProduct = allProduct + "!" + product.nameProduct; |
There was a problem hiding this comment.
Если ! используется как некий разделитель, можно завести строковую или Char константу с ним. Тогда будет сразу в коде понятно, для чего добавляется, ниже будет понятно, почему проверяем символ на соответствие !, и уменьшится вероятность ошибки
| if (ruble % 10 == 1){ | ||
| endingRuble = "рубль"; | ||
| } | ||
| else if (ruble % 10 == 2 || ruble % 10 == 3 || ruble % 10 == 4){ |
There was a problem hiding this comment.
ruble % 10 используется несколько раз, можно посчитать один раз и использовать дальше переменную. Ещё условие можно заменить на ... >= 2 && ... <=4
| else if (ruble % 10 == 2 || ruble % 10 == 3 || ruble % 10 == 4){ | ||
| endingRuble = "рубля"; | ||
| } | ||
| else endingRuble = "рублей"; |
There was a problem hiding this comment.
Вместо if-else можно использовать switch
| static void checkQuantityPeople(){ | ||
| while (true) { | ||
| //Проверка ввода пользователя на пустое значение или не целое число до его чтения | ||
| if (scanner.hasNext() && scanner.hasNextInt()) |
There was a problem hiding this comment.
По идее, можно ограничиться проверкой scanner.hasNextInt(), потому что если она даст true, то и scanner.hasNext() должен быть true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.