Repository navigation
Проектная работа №1 - Николаев - #124
Closed
UltravioletDays wants to merge 7 commits into
Closed
UltravioletDays wants to merge 7 commits into
UltravioletDays wants to merge 7 commits into
Conversation
faritowich
reviewed
Nov 12, 2022
| @@ -0,0 +1,18 @@ | |||
| public class Ending { | |||
|
|
|||
| String end(float num) { | |||
There was a problem hiding this comment.
В Java, да и не только, принято называть методы глаголами.
Почитать можно здесь:
https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html
| } else { | ||
| System.out.println("Требуется указать числовое значение!"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Большое количество сплошного кода в одном методе очень затрудняет читаемость кода. Лучше разбивать код на логические блоки и выносить в отдельные методы или классы. Например, можно вынести весь код в циклах while(true), который отвечает за ввод количества гостей/ввод продуктов, в отдельные методы inputGuests, inputProducts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.