[git-webkit] Use info log level instead of warning by JonWBedard · Pull Request #47 · WebKit/WebKit

JonWBedard · 2021-11-30T01:23:14Z

`db136fe`

[git-webkit] Use info log level instead of warning
https://bugs.webkit.org/show_bug.cgi?id=233607
<rdar://problem/85840831 >

Reviewed by Ryan Haddad.

* Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.branch_point): Log to info instead of warning.
(Branch.main): Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:
(Checkout.main): Log to info instead of warning.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Log to info instead of warning.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_commit): Log to info instead of warning.
(PullRequest.main): Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.github): Log to info instead of warning.
(Setup.git): Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch.test_basic_git):
(TestBranch.test_prompt_git):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(TestLand.test_non_editable):
(TestLand.test_with_oops):
(TestLand.test_default):
(TestLand.test_canonicalize):
(TestLand.test_no_svn_canonical_svn):
(TestLand.test_svn):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
(TestSetup.test_svn):
(TestSetup.test_github):


Canonical link: https://commits.webkit.org/244654@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ryanhaddad

Thanks! I think this will make things much easier to parse when using the script.

JonWBedard · 2021-11-30T15:25:14Z

Landed https://commits.webkit.org/244654@main (db136fe)!

JonWBedard · 2021-12-09T21:22:27Z

Extending this in #48

https://bugs.webkit.org/show_bug.cgi?id=243358 Reviewed by Yusuke Suzuki. Add support for ARM64 disassembler comments in jit code. We use a global map of code address -> comments, which is updated during linking. Comments do nothing when dumpDisassembly=0. Also, we opt-out some MacroAssembler files from unified builds to fix build errors caused by a RegisterID symbol conflict that this patch accidentally exposes. Here is an example of a comment: ``` comment(scratchGPR, " = callFrame->callee->executableOrRareData"); emitGetFromCallFrameHeaderPtr(CallFrameSlot::callee, scratchGPR); loadPtr(Address(scratchGPR, JSFunction::offsetOfExecutableOrRareData()), scratchGPR); auto hasExecutable = branchTestPtr(Zero, scratchGPR, TrustedImm32(JSFunction::rareDataTag)); loadPtr(Address(scratchGPR, FunctionRareData::offsetOfExecutable() - JSFunction::rareDataTag), scratchGPR); hasExecutable.link(this); comment(scratchGPR, " = (", scratchGPR, ": Executable)->codeBlock"); loadPtr(Address(scratchGPR, FunctionExecutable::offsetOfCodeBlockFor(kind)), scratchGPR); ``` becomes ``` <44> 0x12e51c02c: ldur x1, [fp, WebKit#24]; %x1 = callFrame->callee->executableOrRareData <48> 0x12e51c030: ldur x1, [x1, WebKit#24] <52> 0x12e51c034: tbz x1, #0, 0x12e51c03c -> <60> <56> 0x12e51c038: ldur x1, [x1, WebKit#47] <60> 0x12e51c03c: ldur x1, [x1, WebKit#96]; %x1 = (%x1: Executable)->codeBlock ``` * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::comment): (JSC::AbstractMacroAssembler::lineComment): (JSC::AbstractMacroAssembler::commentImpl): * Source/JavaScriptCore/assembler/Comments.cpp: Copied from Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp. (JSC::CommentRegistry::initialize): (JSC::CommentRegistry::singleton): * Source/JavaScriptCore/assembler/Comments.h: Added. (JSC::CommentRegistry::WTF_RETURNS_LOCK): (JSC::CommentRegistry::registerCodeRange): (JSC::CommentRegistry::unregisterCodeRange): (JSC::CommentRegistry::comment): (JSC::CommentRegistry::orderedKey): (JSC::CommentRegistry::orderedKeyInverse): * Source/JavaScriptCore/assembler/LinkBuffer.cpp: (JSC::LinkBuffer::linkCode): (JSC::LinkBuffer::linkComments): * Source/JavaScriptCore/assembler/LinkBuffer.h: * Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp: (JSC::tryToDisassemble): * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType): (JSC::AssemblyHelpers::jitAssertCodeBlockMatchesCurrentCalleeCodeBlockOnCallFrame): * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::ExecutableMemoryHandle::~ExecutableMemoryHandle): * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): remove unified sources for macroasm Canonical link: https://commits.webkit.org/253085@main

https://bugs.webkit.org/show_bug.cgi?id=258794 Reviewed by Youenn Fablet. The current WebRTC HEVC is using generic packetization instead of RFC 7789 Packetization. So this is about implementing the RFC 7798 Packetization. Fix HEVC depacketizer issues. (WebKit#185) Enalbing low latency mode for RTC (WebKit#169) Enable HEVC support. (WebKit#165) Fix out-of-bounds write in H265VpsSpsPpsTracker (WebKit#163) Apply fix bitstream logic to RtpVideoStreamReceiver2 (WebKit#142) Add missing CODEC_H265 switch case (WebKit#136) Add HEVC support for iOS/Android (WebKit#68) H265 packetization_mode setting fix (WebKit#53) Add H.265 QP parsing logic (WebKit#47) This patch is extracted from following Open WebRTC Toolkit code changes: <open-webrtc-toolkit/owt-deps-webrtc#185> <open-webrtc-toolkit/owt-deps-webrtc#169> <open-webrtc-toolkit/owt-deps-webrtc#165> <open-webrtc-toolkit/owt-deps-webrtc#163> <open-webrtc-toolkit/owt-deps-webrtc#142> <open-webrtc-toolkit/owt-deps-webrtc#136> <open-webrtc-toolkit/owt-deps-webrtc#68> <open-webrtc-toolkit/owt-deps-webrtc#53> <open-webrtc-toolkit/owt-deps-webrtc#47> co-authoured by: taste1981 <[email protected]> jianjunz <[email protected]> Cyril Lashkevich <[email protected]> Piasy <[email protected]> ShiJinCheng <[email protected]> Andreas Unterhuber <[email protected]> dong-heun <[email protected]> * Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video/video_codec_type.h: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_codec.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_codec.h: (webrtc::VideoCodecH265::operator!= const): * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_decoder_software_fallback_wrapper.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_encoder.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_encoder.h: * Source/ThirdParty/libwebrtc/Source/webrtc/call/rtp_payload_params.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_common.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_common.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/media/base/media_constants.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/media/base/media_constants.h: * Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/internal_decoder_factory.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.h: (webrtc::RtpPacketizerH265::PacketUnit::PacketUnit): (webrtc::VideoRtpDepacketizerH265::~VideoRtpDepacketizerH265): Deleted. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_video_header.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/h265/include/h265_globals.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/encoded_frame.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/include/video_codec_interface.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/packet_buffer.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/experiments/min_video_bitrate_experiment.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.h: * Source/ThirdParty/libwebrtc/Source/webrtc/test/scenario/video_stream.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/test/video_codec_settings.h: (webrtc::test::CodecSettings): * Source/ThirdParty/libwebrtc/Source/webrtc/video/config/video_encoder_config.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/config/video_encoder_config.h: * Source/ThirdParty/libwebrtc/Source/webrtc/video/encoder_overshoot_detector.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver2.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver2.h: * Source/ThirdParty/libwebrtc/Source/webrtc/video/send_statistics_proxy.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/video_stream_encoder.cc: * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/267677@main

…ilently dropping (#47) The default mach_msg send-error case dropped the message and continued with its logging hard-disabled (FILE* _d = NULL), hiding any occurrence. Instrumented + exercised heavily (8+ sites, video, scroll): ZERO occurrences, so the historical IOSurface INVALID_RIGHT errors (compositing #56) no longer happen in normal use. Replace the dead debug block with a single WTFLogAlways so the case is no longer silent/hidden, keeping the graceful per-send failure (vs aborting the whole process). Removes dead scaffolding. Co-Authored-By: Claude Opus 4.8 <[email protected]>

JonWBedard self-assigned this Nov 30, 2021

JonWBedard requested review from aproskuryakov, dewei-zhu, ryanhaddad and sundiamonde November 30, 2021 01:24

ryanhaddad approved these changes Nov 30, 2021

View reviewed changes

JonWBedard merged commit db136fe into WebKit:main Nov 30, 2021

JonWBedard force-pushed the eng/warning-to-info branch from 8402726 to db136fe Compare November 30, 2021 15:25

JonWBedard deleted the eng/warning-to-info branch November 30, 2021 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[git-webkit] Use info log level instead of warning#47

[git-webkit] Use info log level instead of warning#47
JonWBedard merged 0 commit into
WebKit:mainfrom
JonWBedard:eng/warning-to-info

JonWBedard commented Nov 30, 2021 •

edited

Loading

Uh oh!

ryanhaddad left a comment

Uh oh!

JonWBedard commented Nov 30, 2021

Uh oh!

JonWBedard commented Dec 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JonWBedard commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

db136fe

Uh oh!

ryanhaddad left a comment

Choose a reason for hiding this comment

Uh oh!

JonWBedard commented Nov 30, 2021

Uh oh!

JonWBedard commented Dec 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JonWBedard commented Nov 30, 2021 •

edited

Loading

`db136fe`