Skip to content

[ews] Fold Github status bubbles for old commits#3418

Merged
webkit-early-warning-system merged 1 commit into
WebKit:mainfrom
aj062:eng/ews-Fold-Github-status-bubbles-for-old-commits
Aug 17, 2022
Merged

[ews] Fold Github status bubbles for old commits#3418
webkit-early-warning-system merged 1 commit into
WebKit:mainfrom
aj062:eng/ews-Fold-Github-status-bubbles-for-old-commits

Conversation

@aj062

@aj062 aj062 commented Aug 17, 2022

Copy link
Copy Markdown
Member

366d272

[ews] Fold Github status bubbles for old commits
https://bugs.webkit.org/show_bug.cgi?id=244047

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS.generate_comment_text_for_change):
(GitHubEWS.add_or_update_comment_for_change_id):
* Tools/CISupport/ews-app/ews/models/patch.py:
(Change.mark_old_changes_as_obsolete):

Canonical link: https://commits.webkit.org/253535@main

ddc744d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style 🛠 ios 🛠 mac ✅ 🛠 wpe 🛠 🧪 win
✅ 🧪 bindings 🛠 ios-sim 🛠 mac-debug 🛠 gtk 🛠 wincairo
✅ 🧪 webkitperl 🧪 ios-wk2 🛠 mac-AS-debug 🧪 api-gtk
🧪 api-ios 🧪 api-mac
✅ 🛠 tv 🧪 mac-wk1
✅ 🛠 tv-sim 🧪 mac-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim

@aj062 aj062 self-assigned this Aug 17, 2022
@aj062 aj062 added Other Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels Aug 17, 2022
@aj062
aj062 requested a review from dcrousso August 17, 2022 19:28
@aj062

aj062 commented Aug 17, 2022

Copy link
Copy Markdown
Member Author

Sample run: #933 (comment)

@aj062 aj062 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 17, 2022
https://bugs.webkit.org/show_bug.cgi?id=244047

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS.generate_comment_text_for_change):
(GitHubEWS.add_or_update_comment_for_change_id):
* Tools/CISupport/ews-app/ews/models/patch.py:
(Change.mark_old_changes_as_obsolete):

Canonical link: https://commits.webkit.org/253535@main
@webkit-early-warning-system
webkit-early-warning-system force-pushed the eng/ews-Fold-Github-status-bubbles-for-old-commits branch from ddc744d to 366d272 Compare August 17, 2022 19:40
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 253535@main (366d272): https://commits.webkit.org/253535@main

Reviewed commits have been landed. Closing PR #3418 and removing active labels.

@webkit-early-warning-system
webkit-early-warning-system merged commit 366d272 into WebKit:main Aug 17, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 17, 2022
@aj062
aj062 deleted the eng/ews-Fold-Github-status-bubbles-for-old-commits branch August 17, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants