[webkitscmpy] Generalize pull-request title generation.#28
Closed
JonWBedard wants to merge 1 commit into
Closed
Conversation
dewei-zhu
reviewed
Oct 29, 2021
Contributor
There was a problem hiding this comment.
This is O(n^2) way to calculate common-prefix [note str.startswith is O(n)], where can we directly implement it with O(n).
Member
Author
There was a problem hiding this comment.
Turns out, os implements this anyways, so we can just use that.
JonWBedard
force-pushed
the
eng/title-generation
branch
2 times, most recently
from
October 29, 2021 17:15
8c77ddd to
12bb007
Compare
dewei-zhu
approved these changes
Nov 1, 2021
https://bugs.webkit.org/show_bug.cgi?id=232463 <rdar://problem/84784354> Reviewed by Dewei Zhu. * Scripts/libraries/webkitscmpy/setup.py: Bump version. * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.title_for): Compute pull-request title for a set of commits. (PullRequest.main): Generalize pull-request title generation.
JonWBedard
force-pushed
the
eng/title-generation
branch
from
November 2, 2021 14:41
12bb007 to
5473ad2
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5473ad2