[webkitscmpy] Filter approvers by status#17
Closed
JonWBedard wants to merge 1 commit into
Closed
Conversation
JonWBedard
force-pushed
the
eng/filter-approvers-by-status
branch
from
October 19, 2021 18:21
4d42994 to
61d2ad9
Compare
https://bugs.webkit.org/show_bug.cgi?id=231843 <rdar://problem/84320934> Reviewed by Dewei Zhu. If a project defines statuses for it's contributors, we only want to allow reviewers to approve changes. * Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: (Contributor): Add reviewer status. (Contributor.Mapping.load): Keep track of possible statuses. (Contributor.Mapping.__init__): Ditto. (Contributor.Mapping.add): Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: (BitBucket.PRGenerator.PullRequest): If a project defines a reviewer status, enforce it. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.PRGenerator._contributor): Handle case where no name is defined. (GitHub.PRGenerator.reviewers): If a project defines a reviewer status, enforce it. * Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
JonWBedard
force-pushed
the
eng/filter-approvers-by-status
branch
from
October 19, 2021 18:25
61d2ad9 to
b7ef05a
Compare
Member
Author
webkit-commit-queue
pushed a commit
to hyjorc1/WebKit
that referenced
this pull request
Apr 4, 2025
…rtions https://bugs.webkit.org/show_bug.cgi?id=291090 rdar://148601073 Reviewed by Yusuke Suzuki. This patch enhances loop unrolling debugging by adding support for tracking the original source block (cloneSource) for each cloned basic block in DFGBasicBlock. The cloneSource pointer is enabled only under ASSERT_ENABLED to avoid runtime overhead in release builds. Additionally, Graph::dumpBlockHeader() now prints the clone source block if available, improving traceability during debugging and validation of loop unrolling logic. After loop unrolling, we might see output like the following, where block 17 is a clone of block 9: 9 24: Block WebKit#9 (bc#52): 0 9 24: D@62:<!0:-> LoopHint(MustGen, W:SideState, bc#52, ExitValid) ... 17 24: Block WebKit#17<-WebKit#9 (bc#52): 0 17 24: D@256:<!0:-> LoopHint(MustGen, W:SideState, bc#52, ExitValid) ... * Source/JavaScriptCore/dfg/DFGBasicBlock.h: * Source/JavaScriptCore/dfg/DFGGraph.cpp: (JSC::DFG::Graph::dumpBlockHeader): * Source/JavaScriptCore/dfg/DFGLoopUnrollingPhase.cpp: (JSC::DFG::LoopUnrollingPhase::unrollLoop): Canonical link: https://commits.webkit.org/293265@main
Wowfunhappy
referenced
this pull request
in Wowfunhappy/WebKit
Jun 15, 2026
…MinimalPageClient) setAcceptsMouseMovedEvents for hover/:hover + cursor updates, fill MinimalPageClient stubs (context menu, <select> popup, form-validation, offscreen snapshots), color picker, editor. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Wowfunhappy
referenced
this pull request
in Wowfunhappy/WebKit
Jun 18, 2026
The backport installed a global NSEvent monitor (+[WKView installEventMonitorOnce]) that intercepted mouse/scroll/key events and dispatched them to WKView, on the belief that layer-tree mirror subviews intercepted hit-testing. That was a MISDIAGNOSIS: WKView hosts the WebContent layer tree as a plain CALayer sublayer of its backing layer (MinimalPageClient enterAcceleratedCompositingMode/setRemoteLayerTreeRootNode, [[m_view layer] addSublayer:]) with ZERO NSView subviews. CALayers don't participate in NSView -hitTest:, so nothing ever intercepted events. Worse, the monitor consumed events before -[NSWindow sendEvent:] (where AppKit activates the window on click), creating the very click-to-activate problem it then re-patched. Remove the monitor and rely on AppKit's natural responder chain; WKView's own scrollWheel:/keyDown:/mouseDown:/mouseMoved: handlers receive events directly. Keep the -hitTest: override as upstream-equivalent insurance (upstream WebViewImpl::hitTest does the same redirect). Verified live: main-view links/scroll/typing/right-click; hover (#17) fires :hover on a fresh page AND with the address bar focused; Reader scroll (#39) works via natural routing to the topmost ReaderWKView; and every secondary WKView that relied on the monitor -- uBlock popover (#14/#23), Web Inspector (#16), App Store (#72), Top Sites (#13), Preferences>Extensions (#24) -- stays interactive. No crashes. Retires the #62 event-monitor keystone and supersedes #39's monitor routing. (The DDG-logo black box, a separate #56 IOSurface-backing symptom, is root-caused but not fixed here.) Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b7ef05a