Added the ability to configure cookie options within a route#260
Merged
Conversation
gurgunday
reviewed
Jul 8, 2024
gurgunday
requested changes
Jul 9, 2024
gurgunday
left a comment
gurgunday
left a comment
Member
There was a problem hiding this comment.
#260 (comment) needs resolution
Co-authored-by: Gürgün Dayıoğlu <[email protected]> Signed-off-by: Oleg Gheorghita <[email protected]>
Contributor
Author
|
@gurgunday, I updated Override global options test with regenerate changes, is that ok or would you like to add it as a separate test? |
Contributor
Author
|
@mcollina @gurgunday can we merge or something else is required? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the ability to configure cookie options within a route. Relates to #257
Checklist
npm run testandnpm run benchmarkand the Code of conduct