Repository navigation
Fix for #118 - Needs discussing - #164
Merged
Merged
Conversation
Contributor
|
Awesome! That's a s*&^ load of functions... I'm happy to discuss via Skype. My immediate thinking is that this probably wants to go into a separate branch until the tests and build are working... I think I'll need to create a new branch? |
Contributor
Author
|
Yes if you could create a new branch "split" that would be great and I'll get working on the failing tests too. |
Contributor
|
@kilasuit Branch |
Contributor
Author
|
I'm sure that you can reopen and then change the branch it is going to point to |
Contributor
Author
|
Infact I could do it this is now pointing to the split branch 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@iainbrighton - here is the fix for #118 however there are a few points that need discussed possibly better via skype as this is a big change to the module.