Repository navigation
Conversation
| public class Calculator { | ||
|
|
||
| private final static String FINISH = "завершить"; | ||
| private final UserInteractor mUserInteractor; |
There was a problem hiding this comment.
Возможно вас учат венгерской раскладке, но сейчас никто так в андроид разработке не пишет.
Owner
Author
There was a problem hiding this comment.
хорошо бы увидеть пример, как пишут) без префикса?
There was a problem hiding this comment.
Да, примерно вот так это выглядит
userInteractor
Можно почитать вот тут
https://ru.wikipedia.org/wiki/CamelCase
There was a problem hiding this comment.
| mUserInteractor.showProductAddSuccessMessage(product); | ||
| totalSum += product.getCost(); | ||
| mStringBuilder.append(product.getName()).append("\n"); | ||
| } while (!FINISH.equalsIgnoreCase(mUserInteractor.requestString())); |
There was a problem hiding this comment.
Я бы наоборот, сравнивал введенную строку с твоей константой. Хотя это наверно скорее вкусовщина
|
Окончание слова "рубль" с 11 до 19 неверно |
- добавлена минимальная длина для названия позиции
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Шеф, я сделяль!
(Я студент высшего образования программы онлайн-бакалавриата, трек Android-разработки)