Migrate IexecPoco2#reveal unit tests - #114
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #114 +/- ##
========================================
Coverage 83.75% 83.75%
========================================
Files 34 34
Lines 1077 1077
Branches 222 222
========================================
Hits 902 902
Misses 175 175 ☔ View full report in Codecov by Sentry. |
james-toussaint
marked this pull request as ready for review
August 28, 2024 12:54
james-toussaint
commented
Aug 28, 2024
zguesmi
reviewed
Aug 28, 2024
Member
There was a problem hiding this comment.
IexecPoco2.reveal.test.ts or IexecPoco2-reveal.test.ts ?
Contributor
Author
There was a problem hiding this comment.
I suggest to harmonize all poco test filenames when migration is completed, are you okay with that?
| ).to.be.revertedWithoutReason(); // require#5 | ||
| }); | ||
|
|
||
| it('Should not reveal when no able to prove result ownership', async () => { |
Member
There was a problem hiding this comment.
Maybe a better way to put it, is to contribute with another worker's valid contribution (result hash and seal of worker2).
Contributor
Author
There was a problem hiding this comment.
If you want I can change
.contribute(
[...]
ethers.utils.hexZeroPad('0xbad5ea1', 32), // bad seal
[...]
)
to something like:
.contribute(
[...]
buildResultHashAndResultSeal(taskId, resultDigest, worker2).resultSeal // stolen result seal from another worker
[...]
)
?
Contributor
Author
There was a problem hiding this comment.
zguesmi
approved these changes
Aug 28, 2024
| ).to.be.revertedWithoutReason(); // require#5 | ||
| }); | ||
|
|
||
| it('Should not reveal when no able to prove result ownership', async () => { |
Member
There was a problem hiding this comment.
Suggested change
| it('Should not reveal when no able to prove result ownership', async () => { | |
| it('Should not reveal when unable to prove result ownership', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.