This repository was archived by the owner on Jan 9, 2023. It is now read-only.
- To ensure all transactions are finalized and temp files cleaned up,… - #139
Merged
Conversation
… wait for 'finish' event on CommandProcessor after socket disconnect, before un-piping streams. - Fix indentation
… handling I/O (Issue #137) - Fix npm audit warnings
…event nulls out the instance reference during the while loop
![hackerone-code[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here - or - cancel by adding [!pr] to the title of the pull request.
|
|
||
| this._server = net.createServer(socket => { | ||
| helpers.log(consts.LOG_INFO, `${socket.remoteAddress}:${socket.remotePort} connected.`); | ||
| const remoteAddress = socket.remoteAddress; |
There was a problem hiding this comment.
Good call, this makes the template literals easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… wait for 'finish' event on CommandProcessor after socket disconnect, before un-piping streams.